test: include tests for user task filter services and increase coverage variable tests #19434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romansmirnov
requested changes
Jun 18, 2024
There was a problem hiding this comment.
@nathansandi, the test coverage has to be increased here. IMO, we should do the following
- Test all filter options
- Test variations of specific filter options (like passing only one value or multiple values, ...)
- Test the sorting options
nathansandi
changed the title
nathansandi
changed the title
nathansandi
changed the base branch from
zeebe/taskquery-service
to
zeebe/variables-query-service
feature: increase test coverage and remove variable query
nathansandi
force-pushed
the
zeebe/user-task-camunda-tests
branch
from
3cd95fa
to
d1914a2
Compare
nathansandi
requested review from
romansmirnov
and removed request for
tmetzke and
marcosgvieira
Thank you @romansmirnov I increased the test coverage over here to check if the filters has being applying as well the sort. |
service/src/main/java/io/camunda/service/transformers/filter/UserTaskFilterTransformer.java
Show resolved
Hide resolved
Base automatically changed from
zeebe/variables-query-service
to
zeebe/taskquery-service
June 19, 2024 13:16
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
## Description Create the User Task Filter/Query on Camunda Service Unit tests available on this Pull Request: #19434 Note: This filter will only contemplate User Task, to filter user task variables, this logic will be handled on the endpoint business logic for the performance reasons, only we will have the variable service, and we can divide the search by the tasks that are running vs. tasks that are completed. The variable service is available on this Pull Request: #19385 ## How to test? Example of Java Application ``` public class TestApplication { public static void main(final String[] args) { final var serverUrl = "http://localhost:9200"; final var restClient = RestClient.builder(HttpHost.create(serverUrl)).build(); final var transport = new RestClientTransport(restClient, new JacksonJsonpMapper()); final var esClient = new ElasticsearchClient(transport); final var dataStoreClient = new ElasticsearchSearchClient(esClient); final var camundaServices = new CamundaServices(dataStoreClient); final SearchQueryResult<UserTaskEntity> result = camundaServices .userTaskServices() .search( (q) -> q.page((p) -> p.size(100)) .filter((p) -> p.taskStates("COMPLETED")) .sort((s) -> s.startDate().desc())); result.items().stream().forEach(System.out::println); System.exit(-1); } } ``` ## Related issues closes ##19210
romansmirnov
approved these changes
Jun 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit test implementation for the follow Pull-Request:
#19273
closes ##19210