Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CRUD for groups with IDs #19497

Merged
5 commits merged into from
Jun 20, 2024
Merged

feat: CRUD for groups with IDs #19497

5 commits merged into from
Jun 20, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2024

Description

  • groups support CRUD actions by ID now
  • contains several smaller adaptations and fixes around users and groups

Related issues

closes https://github.com/camunda-cloud/identity/issues/2965

@ghost ghost self-assigned this Jun 18, 2024
@github-actions github-actions bot added the component/identity Related to the Identity component/team label Jun 18, 2024
@ghost ghost self-requested a review June 18, 2024 15:04
Copy link
Contributor

@dlavrenuek dlavrenuek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion from my side, looks good otherwise.

…ame group method and change to updateGroup
@ghost ghost requested review from maryarm and dlavrenuek June 20, 2024 07:09
Copy link
Contributor

@dlavrenuek dlavrenuek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking my comments into account. Looks good from my side 👍

@ghost ghost added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit b561ecd Jun 20, 2024
26 checks passed
@ghost ghost deleted the 2862-crud-groups-identity-backend branch June 20, 2024 08:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/identity Related to the Identity component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants