feat: introduce Identity UI #19533
Merged
feat: introduce Identity UI #19533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/zeebe
Tasklist Test Results146 files ±0 146 suites ±0 1h 33m 11s ⏱️ - 2m 26s Results for commit 72390fb. ± Comparison against base commit 9e5f5fb. This pull request removes 13 and adds 13 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
ghost
reviewed
Jun 20, 2024
dist/src/main/java/io/camunda/identity/controllers/IdentityIndexController.java
Outdated
Show resolved
Hide resolved
ghost
approved these changes
Jun 20, 2024
maryarm
approved these changes
Jun 20, 2024
| @@ -53,6 +54,8 @@ public void initialize(final ConfigurableApplicationContext context) { | |||
| propertyMap.put(CAMUNDA_WEBAPPS_DEFAULT_APP_PROPERTY, TASKLIST.getId()); | |||
| propertyMap.put( | |||
| SERVER_SERVLET_SESSION_COOKIE_NAME_PROPERTY, TasklistURIs.COOKIE_JSESSIONID); | |||
| } else if (activeProfiles.contains(IDENTITY.getId())) { | |||
There was a problem hiding this comment.
Does this logic means that when identity is set in active profiles as the last one, then the default ui is going to be identity's ui?
There was a problem hiding this comment.
Not quite, it means that if Identity is present in the active profiles and no other web app profile (operate/tasklist) is set, then Identity will be the default UI (visiting localhost:8080 or localhost:8080/identity will work). If another webapp profile is there then Identity will be only found on localhost:8080/identity
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Camunda Indentity</title> | ||
| <title>Camunda Identity</title> |
There was a problem hiding this comment.
We will have another opportunity for including easter eggs 🙈
Ben-Sheppard
force-pushed
the
identity/support-webjar-for-ui
branch
from
57b28cf
to
0774bce
Compare
|
Just wanted to update you @maryarm and @steff46 after your reviews. I spotted an issue when trying to start for example just the broker with the As we have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Identity UI (webjar), it can be served by using the
identityprofile.