Don't write Job activated record #5991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* job activated record is no longer written to the log. It is already present in JobBatchRecord * Job record is also not copied multiple times just wrapped without variables for state updates
Zelldon
force-pushed
the
zell-no-job-activation
branch
from
bb830cf
to
87cd9d1
Compare
saig0
approved these changes
Dec 10, 2020
engine/src/test/java/io/zeebe/engine/processing/job/ActivateJobsTest.java
Outdated
Show resolved
Hide resolved
|
Ups github scrolled to slow then I mistakenly closed it sorry. Thanks for the review @saig0 Latency metrics are also working now: I will squash your commit and then merge if you accept again 😅 😁 |
Based on not writting job activated record tests are adjusted
Zelldon
force-pushed
the
zell-no-job-activation
branch
from
48c97f5
to
e389e77
Compare
|
bors r+ |
|
Build succeeded: |
|
Will this be flagged by the inconsistency detection? Could it break an update? |
|
I think this will not be detected by our detection. I just tested it with 0.25.2 creating instances, activating jobs etc and then updating to my snapshot. No problems found. The thing is on the earlier version the event exist. The follow up event is tested, whether the source exist and has same key etc. But we will not detect whether we are still writing an event. Maybe @saig0 can explain this better. |
ghost
pushed a commit
that referenced
this pull request
Mar 23, 2021
6603: Remove the job activated intent r=saig0 a=saig0 ## Description * the job activated intent is not used anymore * remove the intent and adjust the ordinals ## Related issues Follow-up of #5991 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [ ] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [ ] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually * [ ] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
npepinpe
added a commit
that referenced
this pull request
Sep 9, 2021
Removes artificial batch size limitation when activating jobs. This was a left over from when we used to also write a Job.ACTIVATED record, which was removed with #5991, but we still kept the max batch length to half of the record length.
9 tasks
ghost
pushed a commit
that referenced
this pull request
Sep 10, 2021
7795: Remove artificial job activation batch size limit r=npepinpe a=npepinpe ## Description This PR removes the artificial limitation of the job batch record length to be half of the maximum message size. This was previously there because we used to write the activated job into the job batch once, and again as a separate record. This was removed in #5991, but we didn't remove the limit. This PR makes it so that we can now activate single jobs whose payload is almost the max message size, minus some framing/header space, and also activate slightly more jobs in a single batch. It's still a little counter intuitive since we need a little extra space, so you can't quite fit exactly the `maxMessageSize` as a variable, but that's anyway not possible to do in most other commands as well. ## Related issues closes #6207 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
…before fully constructed (#5991) * fix(backend): fix race condition where DatabaseInfo bean is accessed before fully constructed * fix integration tests that relied on static application context updates from other tests * Change race condition fix for DatabaseInfo to use DependsOn instead of Autowire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I run a benchmark and saw no problems, only with the Job activation metrics, which I have fixed afterwards.
Base
General
Resources
Latency
No activated job event
General
Resources
Latency
I set up a new benchmark with the metrics fix.
Related issues
closes #2182
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: