[Backport/stable 1.2] Fix ZeebePartition can be closed when there are ongoing transitions #8436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebePartition When `super.closeAsync` is called, it discards jobs from the Actor's queue. This resulted in an ongoing transition to get stuck, because the jobs related to it were discarded. Transition to inactive triggered by the close would then never completes, because it is waiting for the ongoing transition to complete. Thus ZeebePartition cannot be closed. In this commit, we fix this behavior by ensuring that transitionToActive is called before actor close is requested. We also ensure that no new transitions can be enqueued, once the closing is started. This is important because we don't want new transition after it has all steps are closed by transitioning to inactive. (cherry picked from commit 3a7cf18)
…oing transitions (cherry picked from commit a47a63a)
|
@oleschoenburg There were some merge conflicts. So I did not backport some commits that contains only refactoring. |
lenaschoenburg
approved these changes
Dec 20, 2021
Yes. That was intentionally left out, as there were lot of conflicts. Besides that code is not "on" by default in this version. It is the new transition logic which we disabled due to the bugs we found in 1.2. |
|
bors merge |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8344
closes #7981
Due to merge conflicts, the commits that refactored the code are not backported.