-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(atomix): faster RaftRule
tests
#8501
Conversation
The default config in `RaftRule` used very long heartbeat intervals and election timeouts. Here we adjust the values for both to match what is being used in `RaftTest`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks 💪 I hope that we not get more flaky tests with that 🤷♂️ I'm looking forward to the time when we have fully control over the clock, like with an actor clock so we can better control the tests.
bors r+ |
8501: test(atomix): faster `RaftRule` tests r=oleschoenburg a=oleschoenburg ## Description The default config in `RaftRule` used very long heartbeat intervals and election timeouts. Here we adjust the values for both to match what is being used in `RaftTest`. Locally this reduces the time needed for `RaftFailoverTest` from ~3.5 minutes to ~1.5 minutes. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Build failed: |
Bors r+ |
Successfully created backport PR #8518 for |
Successfully created backport PR #8519 for |
8519: [Backport stable/1.3] test(atomix): faster `RaftRule` tests r=oleschoenburg a=github-actions[bot] # Description Backport of #8501 to `stable/1.3`. relates to 8536: [Backport stable/1.3] Always exit on unrecoverable VM errors r=oleschoenburg a=github-actions[bot] # Description Backport of #8327 to `stable/1.3`. relates to #7807 8538: [Backport stable/1.3] fix: print correct json input r=Zelldon a=github-actions[bot] # Description Backport of #8522 to `stable/1.3`. relates to #8284 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Description
The default config in
RaftRule
used very long heartbeat intervals and election timeouts.Here we adjust the values for both to match what is being used in
RaftTest
.Locally this reduces the time needed for
RaftFailoverTest
from ~3.5 minutes to ~1.5 minutes.