Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomix): faster RaftRule tests #8501

Merged
1 commit merged into from
Jan 4, 2022
Merged

Conversation

lenaschoenburg
Copy link
Member

Description

The default config in RaftRule used very long heartbeat intervals and election timeouts.
Here we adjust the values for both to match what is being used in RaftTest.

Locally this reduces the time needed for RaftFailoverTest from ~3.5 minutes to ~1.5 minutes.

The default config in `RaftRule` used very long heartbeat intervals and
election timeouts. Here we adjust the values for both to match
what is being used in `RaftTest`.
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks 💪 I hope that we not get more flaky tests with that 🤷‍♂️ I'm looking forward to the time when we have fully control over the clock, like with an actor clock so we can better control the tests.

@lenaschoenburg
Copy link
Member Author

bors r+

ghost pushed a commit that referenced this pull request Jan 3, 2022
8501: test(atomix): faster `RaftRule` tests r=oleschoenburg a=oleschoenburg

## Description

The default config in `RaftRule` used very long heartbeat intervals and election timeouts.
Here we adjust the values for both to match what is being used in `RaftTest`.

Locally this reduces the time needed for `RaftFailoverTest` from ~3.5 minutes to ~1.5 minutes.

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@ghost
Copy link

ghost commented Jan 3, 2022

Build failed:

@Zelldon
Copy link
Member

Zelldon commented Jan 4, 2022

Bors r+

@ghost ghost merged commit 06f2f68 into develop Jan 4, 2022
@ghost ghost deleted the decrease-raftrule-timeouts branch January 4, 2022 16:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

Successfully created backport PR #8518 for stable/1.2.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

Successfully created backport PR #8519 for stable/1.3.

ghost pushed a commit that referenced this pull request Jan 4, 2022
8519: [Backport stable/1.3] test(atomix): faster `RaftRule` tests r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8501 to `stable/1.3`.

relates to 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
ghost pushed a commit that referenced this pull request Jan 4, 2022
8518: [Backport stable/1.2] test(atomix): faster `RaftRule` tests r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8501 to `stable/1.2`.

relates to 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
ghost pushed a commit that referenced this pull request Jan 6, 2022
8519: [Backport stable/1.3] test(atomix): faster `RaftRule` tests r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8501 to `stable/1.3`.

relates to 

8536: [Backport stable/1.3] Always exit on unrecoverable VM errors r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8327 to `stable/1.3`.

relates to #7807

8538: [Backport stable/1.3] fix: print correct json input r=Zelldon a=github-actions[bot]

# Description
Backport of #8522 to `stable/1.3`.

relates to #8284

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@npepinpe npepinpe added the version:1.3.1 Marks an issue as being completely or in parts released in 1.3.1 label Jan 17, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:1.3.1 Marks an issue as being completely or in parts released in 1.3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants