Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3]: test: increment time continously #8512

Merged
1 commit merged into from
Jan 4, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Jan 4, 2022

Description

Backports #8508 problems with cherry-pick, because of the import order.

In order to prevent for flakiness the time needs to be increased
everytime so we can retrigger the position distribution.

Related issues

closes #8475

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bors r+

ghost pushed a commit that referenced this pull request Jan 4, 2022
8512: [Backport 1.3]: test: increment time continously r=deepthidevaki a=Zelldon



## Description

Backports #8508 problems with cherry-pick, because of the import order.

> In order to prevent for flakiness the time needs to be increased
everytime so we can retrigger the position distribution.
<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #8475



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@deepthidevaki
Copy link
Contributor

bors r-

There is build failure.

@ghost
Copy link

ghost commented Jan 4, 2022

Canceled.

In order to prevent for flakiness the time needs to be increased
everytime so we can retrigger the position distribution.
@Zelldon
Copy link
Member Author

Zelldon commented Jan 4, 2022

Sorry @deepthidevaki I fixed the formatting issues. Somehow the order was wrong after fixing the cherry-pick 🤷

bors r+

ghost pushed a commit that referenced this pull request Jan 4, 2022
8512: [Backport 1.3]: test: increment time continously r=Zelldon a=Zelldon



## Description

Backports #8508 problems with cherry-pick, because of the import order.

> In order to prevent for flakiness the time needs to be increased
everytime so we can retrigger the position distribution.
<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #8475



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@ghost
Copy link

ghost commented Jan 4, 2022

This PR was included in a batch that successfully built, but then failed to merge into release-1.3.0 (it was a non-fast-forward update). It will be automatically retried.

@ghost
Copy link

ghost commented Jan 4, 2022

Build succeeded:

@ghost ghost merged commit c8ba2fa into release-1.3.0 Jan 4, 2022
@ghost ghost deleted the zell-bp-1_3-8505-8475 branch January 4, 2022 14:31
@korthout
Copy link
Member

korthout commented Jan 4, 2022

@Zelldon This commit was merged into release-1.3.0 after the release was build. It will need to be backported again to stable/1.3

@Zelldon
Copy link
Member Author

Zelldon commented Jan 4, 2022

yeay

ghost pushed a commit that referenced this pull request Jan 4, 2022
8517: [Backport 1.3]: test: increment time continously r=Zelldon a=Zelldon

## Description

Due to the release the merged was merged not into stable #8512 (comment)

<!-- Please explain the changes you made here. -->
Backport #8505

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #8475



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
ghost pushed a commit that referenced this pull request Jan 4, 2022
8517: [Backport 1.3]: test: increment time continously r=Zelldon a=Zelldon

## Description

Due to the release the merged was merged not into stable #8512 (comment)

<!-- Please explain the changes you made here. -->
Backport #8505

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #8475



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants