Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/1.3] fix(log/stream): ensure the appender future always gets completed #8628

Merged
1 commit merged into from
Jan 21, 2022

Conversation

romansmirnov
Copy link
Member

Description

Related issues

backports #8605
relates #7992

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

ghost pushed a commit that referenced this pull request Jan 21, 2022
8628: [Backport stable/1.3] fix(log/stream): ensure the appender future always gets completed r=oleschoenburg a=romansmirnov

## Description

<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

backports #8605
relates #7992



Co-authored-by: Roman <roman.smirnov@camunda.com>
@ghost
Copy link

ghost commented Jan 21, 2022

Build failed:

@lenaschoenburg
Copy link
Member

Flaky test.

bors retry

@ghost
Copy link

ghost commented Jan 21, 2022

Build succeeded:

@ghost ghost merged commit da9674e into stable/1.3 Jan 21, 2022
@ghost ghost deleted the backport-8605-to-stable/1.3 branch January 21, 2022 09:23
@npepinpe npepinpe added the version:1.3.2 Marks an issue as being completely or in parts released in 1.3.2 label Jan 28, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:1.3.2 Marks an issue as being completely or in parts released in 1.3.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants