Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign versions for deployed decisions and DRGs #8648

Merged
3 commits merged into from
Jan 27, 2022
Merged

Assign versions for deployed decisions and DRGs #8648

3 commits merged into from
Jan 27, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jan 25, 2022 •
edited
Loading

Description

  • check the DMN resources of a deployment if the DRGs/decisions were deployed before
    • a DRG/decision is a duplicate if the latest DRG/decision in the state has the same resource name and the same checksum (similar to the check of BPMN processes)
    • mark duplicated DRG/decisions and assign the latest versions from the state
    • increase the version if the DRG/decision is different from the latest DRG/decision in the state
  • reject deploy command if two DRGs or decisions have the same ID (similar to the check of BPMN process ids)

Related issues

closes #8174

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@saig0
feat(engine): check deployment for duplicated DMN resources
c649dd7 
* check the DMN resources of a deployment if the DRGs/decisions were deployed before
* a DRG/decision is a duplicate if the latest DRG/decision in the state has the same resource name and the same checksum
* mark duplicated DRG/decisions and assign the latest versions from the state
* increase the version if the DRG/decision is different from the latest DRG/decision in the state
@saig0
feat(engine): reject deployment if duplicated IDs
0629de0 
* reject deploy command if two DRGs or decisions have the same ID
* align the behavior to the deployment of BPMN processes
@saig0 saig0 marked this pull request as ready for review January 26, 2022 04:53
@saig0 saig0 requested a review from korthout January 26, 2022 04:53
korthout
korthout approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@korthout korthout left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saig0 This looks great! 🦖

Please consider my comments before merging

engine/src/test/java/io/camunda/zeebe/engine/processing/deployment/DeploymentDmnTest.java Show resolved Hide resolved
...ain/java/io/camunda/zeebe/engine/processing/deployment/transform/DmnResourceTransformer.java Show resolved Hide resolved
...ain/java/io/camunda/zeebe/engine/processing/deployment/transform/DmnResourceTransformer.java Outdated Show resolved Hide resolved
@saig0
Copy link
Member Author

saig0 commented Jan 27, 2022

bors merge

@ghost
Copy link

ghost commented Jan 27, 2022

Build succeeded:

@ghost ghost merged commit 1ab92a6 into develop Jan 27, 2022
@ghost ghost deleted the 8174-dmn-versions branch January 27, 2022 05:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korthout korthout korthout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign the correct version for deployed decisions and DRGs
2 participants
@saig0 @korthout