[Backport stable/1.2] Add API to probe the logstream batch writer if more bytes can be written without writing them #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Adds a new public API method to the Dispatcher, `#canClaimFragmentBatch(int, int)`. This method determines whether the batch with the given fragment count and of the given length can actually be claimed for this dispatcher instance. This method is mostly useful to determine if something will be claimable before you wish to claim it, mostly to avoid having to abort your claim unnecessarily if the batch isn't finished yet when calling this method. (cherry picked from commit 9281e81)
Introduces a new API to the `LogStreamBatchWriter` API, `#canWriteAdditionalEvent(int)`. This API lets one probe whether a batch including an additional event of the given size could be written. While this could be done via tryWrite, there are cases, such as with the job activation, where you want to know if adding data to a record (not to the writer, but the record) will cause it to be unwritable, at which point you want to handle it differently. Rolling back changes to the record itself is more complicated than to the writer, so as a compromise you can probe the writer to know if it will be able to write more bytes before writing them, even, as in our example, to your DTO. (cherry picked from commit e706d94)
Adds a common case test for `canClaimFragmentBatch`. The idea is that the previous test was testing a corner case - i.e. when the given batch length fits the max fragment length, but will not when it's framed and aligned. (cherry picked from commit 471f3c7)
(cherry picked from commit 409a7dc)
Merged
10 tasks
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #8798 to
stable/1.2.relates to #5525