Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename distribution artifact from camunda-cloud-zeebe to camunda-zeebe #8912

Merged
3 commits merged into from
Mar 16, 2022

Conversation

npepinpe
Copy link
Member

@npepinpe npepinpe commented Mar 15, 2022

Description

This PR renames the distribution artifact produced by dist to camunda-zeebe. This aligns the artifact names with other Camunda 8 artifacts in order to avoid confusion between Camunda and Camunda Cloud.

NOTE: I haven't tested the release since our release job picks up the scripts from main. I will test it once it's merged, but before the release. I anyway need to test the repo move before the release in April, so I would test them both then.

Related issues

closes #8911

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in the sense that I checked that there are no more mentions of camunda-cloud-zeebe, but really I have no idea what might break because of this 😅

@npepinpe
Copy link
Member Author

I think renaming the artifact won't break much, as it's pretty self contained. It might break other scripts which expect the name in other repositories, but I'm not really aware of any.

@npepinpe
Copy link
Member Author

Just fixed merge conflicts, nothing else.

bors merge

ghost pushed a commit that referenced this pull request Mar 16, 2022
8912: Rename distribution artifact from camunda-cloud-zeebe to camunda-zeebe r=npepinpe a=npepinpe

## Description

This PR renames the distribution artifact produced by `dist` to `camunda-zeebe`. This aligns the artifact names with other Camunda 8 artifacts in order to avoid confusion between Camunda and Camunda Cloud.

NOTE: I haven't tested the release since our release job picks up the scripts from `main`. I will test it once it's merged, but before the release. I anyway need to test the repo move before the release in April, so I would test them both then.

## Related issues

closes #8911



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@ghost
Copy link

ghost commented Mar 16, 2022

Build failed:

@npepinpe
Copy link
Member Author

bors r+

@ghost
Copy link

ghost commented Mar 16, 2022

@ghost ghost merged commit 69dc89d into main Mar 16, 2022
@ghost ghost deleted the 8911-rename-dist branch March 16, 2022 16:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename distribution to camunda-zeebe
2 participants