refactor: use foreign keys for decisions #8939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
pihme
suggested changes
Mar 21, 2022
engine/src/main/java/io/camunda/zeebe/engine/state/deployment/DbDecisionState.java
Show resolved
Hide resolved
engine/src/main/java/io/camunda/zeebe/engine/state/deployment/DbDecisionState.java
Outdated
Show resolved
Hide resolved
|
@korthout Do you have time to join this review? Especially regarding the changes to the test. |
korthout
approved these changes
Mar 21, 2022
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 21, 2022
8919: Support decision table inputs and outputs without names/labels r=korthout a=korthout ## Description <!-- Please explain the changes you made here. --> A decision tables' inputs and outputs must have an id and can have a name. The name (or label) is not mandatory. Even though the internal decision engine was already able to deal with this, the workflow engine wasn't. It would try to write the EvaluationEvent record with an EvaluatedInputRecord (or EvaluatedOutputRecord) and then fail writing it because of a NullPointerException. This makes sure these records can be written when the name of the input or output is undefined. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #8909 8939: refactor: use foreign keys for decisions r=oleschoenburg a=oleschoenburg ## Description Uses `DbForeignKey` internally to maintain referential integrity within `DbDecisionState` relates to #8930 Co-authored-by: Nico Korthout <nico.korthout@camunda.com> Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed (retrying...): |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
DbForeignKeyinternally to maintain referential integrity withinDbDecisionStaterelates to #8930