Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] Fix ArrayOutOfBounds / collection has wrong type errors by raising an incident #9229

Merged
merged 13 commits into from
Apr 27, 2022
Merged

[Backport stable/8.0] Fix ArrayOutOfBounds / collection has wrong type errors by raising an incident #9229

merged 13 commits into from
Apr 27, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Description

Backport of #9178 to stable/8.0.

relates to #9143

pihme added 13 commits April 26, 2022 10:52
@pihme @github-actions
refactor(engine): extract logic regarding output collections
04ccdc6 
(cherry picked from commit dcee4f3)
@pihme @github-actions
refactor(engine): rename variable
966096d 
(cherry picked from commit 9d5a1eb)
@pihme @github-actions
refactor(engine): move private class up
a78f8d9 
- also rename variables to be more descriptive

(cherry picked from commit 420add6)
@pihme @github-actions
refactor(engine): change construction of class
6dd0d9b 
(cherry picked from commit a10092c)
@pihme @github-actions
test(engine): implement test for #9143
7bc1a56 
(cherry picked from commit e0b6ce5)
@pihme @github-actions
refactor(engine): rename method
060c97c 
(cherry picked from commit 332ed1e)
@pihme @github-actions
fix(engine): detect out of bounds access
9aa075b 
(cherry picked from commit b5b662c)
@pihme @github-actions
refactor(engine): change error type
b24fe02 
(cherry picked from commit 37922e6)
@pihme @github-actions
fix(engine): detect writing to wrong value type
c60d1f8 
- also change variables in tests, which had been confused

(cherry picked from commit 6de9f65)
@pihme @github-actions
test(engine): test incident is raised/resolvable for out of bounds ac…
7a7310d 
…cess to outbound collection

(cherry picked from commit a582de9)
@pihme @github-actions
test(engine): test incident is raised/resolvable for outbound collect…
f70ac5e 
…ion not an array

(cherry picked from commit 1450dc0)
@pihme @github-actions
refactor(engine): rename class
42f5455 
(cherry picked from commit 11c4f39)
@pihme @github-actions
refactor(engine): incorporate review feedback
4685dd2 
(cherry picked from commit bee8749)
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Merged
10 tasks
pihme
pihme approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport of approved change

@pihme
Copy link
Contributor

pihme commented Apr 27, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 6ff034c into stable/8.0 Apr 27, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-9178-to-stable/8.0 branch April 27, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pihme pihme pihme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pihme