-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java client accepts topologies with DEAD
partitions
#9410
Conversation
3085888
to
1c15228
Compare
@saig0 Since you reacted to the original issue, are you interested in reviewing this? 😉 |
Hm, looks like I can't get Junit 5 to work for the java-client module 🤔
|
Well, that's too bad. I can't really use easy-random for the tests because the Java client needs to be Java 8 compatible and easy-random 5.0 requires Java 11. I also can't use two different versions since that is a dependency convergence issue. @saig0 What do you think, should I just remove the test and leave only the fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleschoenburg thank you for providing a fix 👍
I have suggestion about the test. Please have a look.
clients/java/src/test/java/io/camunda/zeebe/client/impl/response/TopologyImplTest.java
Outdated
Show resolved
Hide resolved
832b68e
to
eaf3cda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oleschoenburg LGTM 👍
bors merge |
Must have admin rights to Repository. |
Must have admin rights to Repository. |
@korthout something is wrong with the backport action 😅 can you have a look? |
Thanks for letting me know. It seems to be related to the request review feature. To request reviews, the @backport-action user must have admin rights to this repo, which it doesn't have. I'll open a bug for it. As a workaround in zeebe, until a fix is available, we could give the backport-action user admin rights to the repo. For example, by adding it to the Zeebe team. However, I don't think we should because the account is not controlled by Camunda, and therefore less secured. Luckily it seems to open PRs correctly. I think the only solution is to disable the feature or make enabling it configurable. However, that will require a new release. |
A new version is released https://github.com/zeebe-io/backport-action/releases/tag/v0.0.8 |
Git push to origin failed for stable/1.3 with exitcode 1 |
Git push to origin failed for stable/8.0 with exitcode 1 |
Haha wow, it picked up the url as a backport comment. You can ignore these last 2 comments. |
Description
The Java client now accepts partitions that are
DEAD
instead of throwing an exception. I've also added a test that generates randomized topology responses and ensures that they are accepted by the Java client.closes #9387