Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase DRG version if another DRG was deployed with the same decisions #9466

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Increase DRG version if another DRG was deployed with the same decisions #9466

merged 4 commits into from
Jun 1, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented May 31, 2022 •
edited
Loading

Description

  • change the duplicate check of a DRG
  • check that all decisions belong to the lastest DRG
  • if another DRG was deployed with the same decision id then it detects that the decision belongs to the other DRG

Related issues

closes #9272

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

saig0 added 4 commits May 31, 2022 13:55
@saig0
test(engine): verify decision evaluation
4920e75 
* add a regression test for the case that two DRGs are deployed with a different id but the same decision id
@saig0
test(engine): change expected DRG version
47550bb 
* adjust the test case to reflect that we want to detect the change in the DRG and increase the version
@saig0
fix(engine): detect DRG duplication based on decisions
30c0e73 
* a DRG is only marked as duplicate if the content is the same and all containing decisions belongs to it
* previously, the duplication checked only the content
* the check of the decisions avoids version conflicts if another DRG is deployed with a different id but the same decision ids
@saig0
refactor(engine): split duplicate check method
aa5d49d 
* split method of DRG duplicate check to be more explicit and align with the new check method for decisions
@github-actions
Copy link
Contributor

Unit Test Results

   714 files  ±    0     714 suites  ±0   17m 42s ⏱️ - 1m 32s
5 300 tests  - 233  5 295 ✔️  - 233  5 💤 ±0  0 ❌ ±0 
5 464 runs   - 233  5 459 ✔️  - 233  5 💤 ±0  0 ❌ ±0 

Results for commit aa5d49d. ± Comparison against base commit cd389d7.

@saig0 saig0 marked this pull request as ready for review May 31, 2022 12:57
remcowesterhoud
remcowesterhoud approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I have nothing to add 🏆

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit e848940 into main Jun 1, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9272-decision-evaluation-event branch June 1, 2022 10:35
@backport-action backport-action mentioned this pull request Jun 1, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #9475 for stable/8.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Jun 1, 2022
@zeebe-bors-camunda @saig0
merge: #9475
37cc931 
9475: [Backport stable/8.0] Increase DRG version if another DRG was deployed with the same decisions r=saig0 a=backport-action

# Description
Backport of #9466 to `stable/8.0`.

relates to #9272

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IllegalStateException when writing decision evaluation event
4 participants
@saig0 @backport-action @remcowesterhoud @npepinpe