Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer timer triggered event with process instance key #9520

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 8, 2022

Description

  • minimal change in the timer processor to write the timer triggered event with the key of the created process instance

Related issues

closes #9519

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

saig0 added 2 commits June 8, 2022 09:25
* add a test case to verify that the timer triggered event is written with the key of the created process instance
* the key of the created process instance is known when the timer start event is triggered
* set the key of the process instance for the timer event to make it observable that the instance was created by the this timer
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Unit Test Results

   777 files  ±  0     777 suites  ±0   1h 34m 49s ⏱️ - 3m 58s
5 452 tests  - 70  5 445 ✔️  - 70  7 💤 ±0  0 ±0 
5 622 runs   - 70  5 615 ✔️  - 70  7 💤 ±0  0 ±0 

Results for commit b6e5b35. ± Comparison against base commit 93f7bfc.

@saig0 saig0 marked this pull request as ready for review June 8, 2022 07:50
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks!

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Jun 9, 2022
9520: Writer timer triggered event with process instance key r=remcowesterhoud a=saig0

## Description

* minimal change in the timer processor to write the timer `triggered` event with the key of the created process instance 

## Related issues

closes #9519



Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

This PR was included in a batch that successfully built, but then failed to merge into main (it was a non-fast-forward update). It will be automatically retried.

zeebe-bors-camunda bot added a commit that referenced this pull request Jun 9, 2022
9520: Writer timer triggered event with process instance key r=remcowesterhoud a=saig0

## Description

* minimal change in the timer processor to write the timer `triggered` event with the key of the created process instance 

## Related issues

closes #9519



Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@saig0
Copy link
Member Author

saig0 commented Jun 10, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Jun 10, 2022
9520: Writer timer triggered event with process instance key r=saig0 a=saig0

## Description

* minimal change in the timer processor to write the timer `triggered` event with the key of the created process instance 

## Related issues

closes #9519



Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@saig0
Copy link
Member Author

saig0 commented Jun 10, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 31b5534 into main Jun 10, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9519-timer-triggered branch June 10, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writer timer triggered event with process instance key
2 participants