[Backport stable/1.3] Allow relaxed instantiation of exporter configuration #9867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where deserialization of exporter configuration was case sensitive, such that a property `NUMBEROFSHARDS` would not map to an instance field `numberOfShards`. This isn't perfect, as now if we have two fields with the same name but different cases, only one of them will be set, using the latest value in the map (where the order is undefined). It should solve the most common cases however. (cherry picked from commit aaab694)
(cherry picked from commit 9df85eb)
npepinpe
changed the title
npepinpe
force-pushed
the
backport-9854-to-stable/1.3
branch
from
c4db2a6
to
6697435
Compare
npepinpe
force-pushed
the
backport-9854-to-stable/1.3
branch
from
6697435
to
b92c837
Compare
|
bors r- |
|
bors merge |
|
👎 Rejected by too few approved reviews |
|
Oops, wrong PR 🙈 |
lenaschoenburg
approved these changes
Jul 26, 2022
npepinpe
force-pushed
the
backport-9854-to-stable/1.3
branch
from
4acbd45
to
2351370
Compare
Convert record to beans, as 1.3 is not on Java 17.
npepinpe
force-pushed
the
backport-9854-to-stable/1.3
branch
from
2351370
to
223e0b3
Compare
|
Forgot that for Jackson compat, I had to transform the records not just to plain classes but to beans. |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #9854 to stable/1.3.
Related issues
backports #9854
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.