feat(jdbc): Add a default value to the Return results parameter (#2345)

camunda · Apr 25, 2024 · 8ac2e90 · 8ac2e90
1 parent fc6eb14
commit 8ac2e90
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json b/connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json
@@ -234,6 +234,7 @@
     "label" : "Return results",
     "description" : "Check this box if the SQL statement return results, e.g. a SELECT or any statement with a RETURNING clause",
     "optional" : false,
+    "value" : false,
     "group" : "query",
     "binding" : {
       "name" : "data.returnResults",
@@ -258,7 +259,7 @@
   }, {
     "id" : "data.variables",
     "label" : "SQL Query variables",
-    "description" : "The variables to use in the SQL query. Could be a list of values (if you used the positional (?) syntax), or a map of names to values (if you used named (:myValue) parameters).",
+    "description" : "The <a href=\"https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/sql/#variables\" target=\"_blank\">variables</a> to use in the SQL query.",
     "optional" : true,
     "feel" : "required",
     "group" : "query",

diff --git a/connectors/jdbc/element-templates/jdbc-outbound-connector.json b/connectors/jdbc/element-templates/jdbc-outbound-connector.json
@@ -229,6 +229,7 @@
     "label" : "Return results",
     "description" : "Check this box if the SQL statement return results, e.g. a SELECT or any statement with a RETURNING clause",
     "optional" : false,
+    "value" : false,
     "group" : "query",
     "binding" : {
       "name" : "data.returnResults",
@@ -253,7 +254,7 @@
   }, {
     "id" : "data.variables",
     "label" : "SQL Query variables",
-    "description" : "The variables to use in the SQL query. Could be a list of values (if you used the positional (?) syntax), or a map of names to values (if you used named (:myValue) parameters).",
+    "description" : "The <a href=\"https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/sql/#variables\" target=\"_blank\">variables</a> to use in the SQL query.",
     "optional" : true,
     "feel" : "required",
     "group" : "query",

diff --git a/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java b/connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java
@@ -16,6 +16,8 @@ public record JdbcRequestData(
             id = "returnResults",
             label = "Return results",
             feel = Property.FeelMode.disabled,
+            defaultValue = "false",
+            defaultValueType = TemplateProperty.DefaultValueType.Boolean,
             group = "query",
             type = TemplateProperty.PropertyType.Boolean,
             description =