fix(generator): FEEL mode = disabled not applied in some cases (#2286)

camunda · Apr 2, 2024 · 8d92aa3 · 8d92aa3
1 parent 552d13b
commit 8d92aa3
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 6 deletions.
diff --git a/connectors/webhook/element-templates/webhook-connector-boundary.json b/connectors/webhook/element-templates/webhook-connector-boundary.json
@@ -83,7 +83,6 @@
         "message" : "can only contain letters, numbers, or single underscores/hyphens and cannot begin or end with an underscore/hyphen"
       }
     },
-    "feel" : "optional",
     "group" : "endpoint",
     "binding" : {
       "name" : "inbound.context",

diff --git a/connectors/webhook/element-templates/webhook-connector-intermediate.json b/connectors/webhook/element-templates/webhook-connector-intermediate.json
@@ -83,7 +83,6 @@
         "message" : "can only contain letters, numbers, or single underscores/hyphens and cannot begin or end with an underscore/hyphen"
       }
     },
-    "feel" : "optional",
     "group" : "endpoint",
     "binding" : {
       "name" : "inbound.context",

diff --git a/connectors/webhook/element-templates/webhook-connector-start-event.json b/connectors/webhook/element-templates/webhook-connector-start-event.json
@@ -79,7 +79,6 @@
         "message" : "can only contain letters, numbers, or single underscores/hyphens and cannot begin or end with an underscore/hyphen"
       }
     },
-    "feel" : "optional",
     "group" : "endpoint",
     "binding" : {
       "name" : "inbound.context",

diff --git a/connectors/webhook/element-templates/webhook-connector-start-message.json b/connectors/webhook/element-templates/webhook-connector-start-message.json
@@ -83,7 +83,6 @@
         "message" : "can only contain letters, numbers, or single underscores/hyphens and cannot begin or end with an underscore/hyphen"
       }
     },
-    "feel" : "optional",
     "group" : "endpoint",
     "binding" : {
       "name" : "inbound.context",

diff --git a/...in/java/io/camunda/connector/generator/java/processor/TemplatePropertyFieldProcessor.java b/...in/java/io/camunda/connector/generator/java/processor/TemplatePropertyFieldProcessor.java
@@ -17,7 +17,6 @@
 package io.camunda.connector.generator.java.processor;
 
 import io.camunda.connector.generator.dsl.DropdownProperty.DropdownPropertyBuilder;
-import io.camunda.connector.generator.dsl.Property.FeelMode;
 import io.camunda.connector.generator.dsl.PropertyBuilder;
 import io.camunda.connector.generator.dsl.PropertyCondition;
 import io.camunda.connector.generator.dsl.PropertyConstraints;
@@ -35,7 +34,7 @@ public void process(Field field, PropertyBuilder builder) {
       return;
     }
     builder.optional(annotation.optional());
-    if (annotation.feel() != FeelMode.disabled && !(builder instanceof DropdownPropertyBuilder)) {
+    if (!(builder instanceof DropdownPropertyBuilder)) {
       builder.feel(annotation.feel());
     }
     if (!annotation.label().isBlank()) {