Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Create Issue Comment Connector: gracefully handle numbers for issueNumber #1378

Open
MaxTru opened this issue Nov 7, 2023 · 2 comments
Labels
kind:bug Something isn't working

Comments

@MaxTru
Copy link
Contributor

MaxTru commented Nov 7, 2023

Describe the Bug

GitHub Create Issue Comment Connector: gracefully handle numbers

Steps to Reproduce

  1. I often extract the issueNumber from a GitHub event. This is then stored as number (see first screenshot)
Bildschirmfoto 2023-11-07 um 10 53 18 2. However, the GitHub Post Connector expects issue number to be a string. However this is not clear from the docs. So * this will not work: Bildschirmfoto 2023-11-07 um 10 54 59 * this will work: Bildschirmfoto 2023-11-07 um 10 55 31

Expected Behavior

It would be super, if the GitHub issue connector could work with issue numbers stored as string or as numbers.

Environment

SaaS as of 07.11.

@MaxTru MaxTru added the kind:bug Something isn't working label Nov 7, 2023
@sbuettner
Copy link
Contributor

We currently cant make use of the string() FEEL function due to this issue: camunda/camunda#9859 (comment)

There seems to be a fix available but its not merged yet: camunda/feel-scala#750

We will try to make use of the function as soon as its working as expected.

@MaxTru
Copy link
Contributor Author

MaxTru commented Nov 13, 2023

To consider: while this is not implemented, one could highlight that is MUST be a number in the docs and/or the field description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants