fix: collect all process definitions before extracting inbound connectors #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfarkas-camunda
deleted the
fix-getting-inbound-connectors-from-operate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
We query operate in the chunks of 20, and only process these 20 process definitions. Processing means activating any inbound connector in it. If you have more then 20 versions of a certain process definition, the application might activate an inbound connector which is not part of the latest version but a previous one. Even if we will override this (deactivate the old one and activate the new one) later, there is still a brief moment when we have the old version as an activated inbound connector, which may lead to unexpected behavior.
Solution
We first collect all the process definitions (not just 20), and only start extracting inbound connectors afterwards. This will result in only processing the latest process definitions as expected.
Related issues
There is no related issue.
closes #