Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ms teams): refresh token can be without client secret, fix create chat method #2275

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix(ms teams): refresh token can be without client secret, fix create chat method #2275

merged 2 commits into from
Mar 28, 2024

Conversation

Oleksiivanov
Copy link
Contributor

@Oleksiivanov Oleksiivanov commented Mar 28, 2024 •
edited

Description

  • For refresh token auth : client secret is optional, depends on whether the client is public or private
  • set topic in the method Create chat available only for group chat
  • added @JsonAlias(value = {"userPrincipalName", "principalName"}) for backward compatibility support

next steps :

Related issues

@Oleksiivanov Oleksiivanov self-assigned this Mar 28, 2024
@Oleksiivanov Oleksiivanov force-pushed the fix-ms-teams-after-regression-test branch from 642a564 to abb16c4 Compare March 28, 2024 12:48
@Oleksiivanov Oleksiivanov marked this pull request as ready for review March 28, 2024 12:52
@Oleksiivanov Oleksiivanov requested a review from a team as a code owner March 28, 2024 12:52
@Oleksiivanov Oleksiivanov added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit f55483b Mar 28, 2024
4 checks passed
@Oleksiivanov Oleksiivanov deleted the fix-ms-teams-after-regression-test branch March 28, 2024 13:22
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release/8.5:

github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
@Oleksiivanov @github-actions
fix(ms teams): refresh token can be without client secret, fix create…
68f3112 
… chat method (#2275)

* fix(ms-teams): add constraint for create chat topic and jsonAlias for principalName

* fix(ms teams): client secret optional for refresh token auth

(cherry picked from commit f55483b)
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
Merged
chillleader pushed a commit that referenced this pull request Mar 28, 2024
@Oleksiivanov @chillleader
fix(ms teams): refresh token can be without client secret, fix create…
86b6419 
… chat method (#2275)

* fix(ms-teams): add constraint for create chat topic and jsonAlias for principalName

* fix(ms teams): client secret optional for refresh token auth

(cherry picked from commit f55483b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chillleader chillleader chillleader approved these changes

@igpetrov igpetrov igpetrov approved these changes

Assignees

@Oleksiivanov Oleksiivanov

Labels
backport release/8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Oleksiivanov @chillleader @igpetrov