-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure,openai): introduced Azure OpenAI prompt connector #2306
Conversation
766df68
to
43d0f68
Compare
LGTM overall, but it's not exactly consistent with the other OpenAI Connector. You can check how internal_systemMessage is handled for instance. Not sure but I guess we should have the same behavior for all our OpenAI connectors, wdyt? ![]() |
Good point. We already discussed that previously with @bastiankoerber. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve then :)
Thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
looks good, i would just remove the prefilled messages / prompts |
526e803
feat(azure,openai): introduced Azure OpenAI prompt connector