Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure,openai): introduced Azure OpenAI prompt connector #2306

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

igpetrov
Copy link
Contributor

@igpetrov igpetrov commented Apr 9, 2024

feat(azure,openai): introduced Azure OpenAI prompt connector

@igpetrov igpetrov requested a review from a team as a code owner April 9, 2024 10:37
@igpetrov igpetrov self-assigned this Apr 9, 2024
@igpetrov igpetrov force-pushed the azure-open-ai branch 2 times, most recently from 766df68 to 43d0f68 Compare April 9, 2024 12:11
@johnBgood
Copy link
Contributor

johnBgood commented Apr 10, 2024

LGTM overall, but it's not exactly consistent with the other OpenAI Connector. You can check how internal_systemMessage is handled for instance.
We're not asking for the complete Json ({"role":"system".....}), we're creating it instead.

Not sure but I guess we should have the same behavior for all our OpenAI connectors, wdyt?
Maybe @YanaSegal @bastiankoerber have an opinion as well?

Screenshot 2024-04-10 at 09 51 56

@igpetrov
Copy link
Contributor Author

LGTM overall, but it's not exactly consistent with the other OpenAI Connector. You can check how internal_systemMessage is handled for instance. We're not asking for the complete Json ({"role":"system".....}), we're creating it instead.

Not sure but I guess we should have the same behavior for all our OpenAI connectors, wdyt? Maybe @YanaSegal @bastiankoerber have an opinion as well?

Good point. We already discussed that previously with @bastiankoerber.
The difference between 'classical' OpenAI / ChatGPT and current connector is that this one is as much technical as possible. Besides, AFAIK, system message adds system role, however, Azure OpenAI allows to pass system, user, assistant, tool, or function roles.

johnBgood
johnBgood previously approved these changes Apr 10, 2024
Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve then :)

@igpetrov
Copy link
Contributor Author

Happy to approve then :)

Thank you :)
I will wait for @bastiankoerber acceptance too

Oleksiivanov
Oleksiivanov previously approved these changes Apr 11, 2024
Copy link
Contributor

@Oleksiivanov Oleksiivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastiankoerber
Copy link

looks good, i would just remove the prefilled messages / prompts

bastiankoerber
bastiankoerber previously approved these changes Apr 16, 2024
@igpetrov igpetrov added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit a81816f Apr 16, 2024
4 checks passed
@igpetrov igpetrov deleted the azure-open-ai branch April 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants