Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): Support response expressions for Webhooks #2309

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

sbuettner
Copy link
Contributor

Refactor verification and response body expression handling

Description

Support a responseExpression property that allow users to define the whole response including the body, status code and headers. Its backwards compatible and supports the already existing responseBodyExpression.

Related issues

closes #2060

Refactor verification and response body expression handling
@sbuettner sbuettner requested a review from a team as a code owner April 11, 2024 15:36
johnBgood
johnBgood previously approved these changes Apr 12, 2024
Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiosity comments, LGTM 🏑

Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sbuettner sbuettner added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit bd786e5 Apr 16, 2024
4 checks passed
@sbuettner sbuettner deleted the 2060-response-expression branch April 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Status code support in response expression
2 participants