Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): support inbound deduplication; boolean props; enhanced conditions #2310

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

chillleader
Copy link
Member

@chillleader chillleader commented Apr 12, 2024

Description

This PR implements inbound deduplication ID support to the element template generator, along with some auxiliary functionality related to new features of the element template JSON schema.

Screenshot 2024-04-16 at 09 27 51
Screenshot 2024-04-16 at 09 16 43
Screenshot 2024-04-16 at 09 28 21

Key features:

  • Deduplication properties are added to generated inbound connector templates
  • They are hidden behind a feature flag that can be enabled in the pom.xml
  • Boolean values (chechboxes) are now supported in the template generator
  • Tooltips can be added to grop labels and properties
  • New condition types are supported, including allMatch and isActive (the latter one determines whether property is visible and not hidden by other conditions).

Related issues

closes #2133

@chillleader chillleader self-assigned this Apr 12, 2024
@chillleader chillleader force-pushed the inbound-deduplication-generator branch from 0ac6914 to 3c688dd Compare April 16, 2024 07:13
@chillleader chillleader marked this pull request as ready for review April 16, 2024 07:24
@chillleader chillleader requested a review from a team as a code owner April 16, 2024 07:24
@chillleader
Copy link
Member Author

fyi @YanaSegal design vs first iteration, feel free to leave comments 🙂

image

Screenshot 2024-04-16 at 09 16 43
Screenshot 2024-04-16 at 09 28 21

johnBgood
johnBgood previously approved these changes Apr 16, 2024
Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing new features thank you 🥇

@YanaSegal
Copy link

Looks good.
Is it possible to add placeholder text in the ID field? If so, we can use this space to guide the user by listing the supported characters.
image

@chillleader
Copy link
Member Author

Is it possible to add placeholder text in the ID field?

Unfortunately no, but I can add another validation rule that will just limit the set of characters the user can input, and show an error message similar to the one in the screenshot in case the field contains some forbidden chars.

@YanaSegal
Copy link

@chillleader, that sounds good. And please, let's cover this in the docs so that if users are unsure what they are doing wrong, they can find guidelines in the documentation.
Thanks :)

@chillleader chillleader added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 585116f Apr 16, 2024
4 checks passed
@chillleader chillleader deleted the inbound-deduplication-generator branch April 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deduplicationId to inbound connector templates using the template generator
3 participants