Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kafka,sqs): support inbound connector deduplication #2340

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat(kafka,sqs): support inbound connector deduplication #2340

merged 1 commit into from
Apr 25, 2024

Conversation

chillleader
Copy link
Member

Description

Adds deduplication configuration to SQS and Kafka inbound connector templates.

Related issues

closes #2133

@chillleader chillleader requested a review from a team as a code owner April 25, 2024 12:22
@chillleader chillleader self-assigned this Apr 25, 2024
johnBgood
johnBgood approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chillleader chillleader added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 2002bb1 Apr 25, 2024
9 checks passed
@chillleader chillleader deleted the deduplication-kafka-sqs branch April 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnBgood johnBgood johnBgood approved these changes

Assignees

@chillleader chillleader

Labels
scope:kafka scope:sqs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deduplicationId to inbound connector templates using the template generator
2 participants
@chillleader @johnBgood