Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jdbc): Add a default value to the Return results parameter #2345

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat(jdbc): Add a default value to the Return results parameter #2345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion connectors/jdbc/element-templates/hybrid/jdbc-outbound-connector-hybrid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@
"label" : "Return results",
"description" : "Check this box if the SQL statement return results, e.g. a SELECT or any statement with a RETURNING clause",
"optional" : false,
"value" : false,
"group" : "query",
"binding" : {
"name" : "data.returnResults",
Expand All @@ -258,7 +259,7 @@
}, {
"id" : "data.variables",
"label" : "SQL Query variables",
"description" : "The variables to use in the SQL query. Could be a list of values (if you used the positional (?) syntax), or a map of names to values (if you used named (:myValue) parameters).",
"description" : "The <a href=\"https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/sql/#variables\" target=\"_blank\">variables</a> to use in the SQL query.",
"optional" : true,
"feel" : "required",
"group" : "query",
Expand Down
3 changes: 2 additions & 1 deletion connectors/jdbc/element-templates/jdbc-outbound-connector.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@
"label" : "Return results",
"description" : "Check this box if the SQL statement return results, e.g. a SELECT or any statement with a RETURNING clause",
"optional" : false,
"value" : false,
"group" : "query",
"binding" : {
"name" : "data.returnResults",
Expand All @@ -253,7 +254,7 @@
}, {
"id" : "data.variables",
"label" : "SQL Query variables",
"description" : "The variables to use in the SQL query. Could be a list of values (if you used the positional (?) syntax), or a map of names to values (if you used named (:myValue) parameters).",
"description" : "The <a href=\"https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/sql/#variables\" target=\"_blank\">variables</a> to use in the SQL query.",
"optional" : true,
"feel" : "required",
"group" : "query",
Expand Down
2 changes: 2 additions & 0 deletions connectors/jdbc/src/main/java/io/camunda/connector/jdbc/model/request/JdbcRequestData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ public record JdbcRequestData(
id = "returnResults",
label = "Return results",
feel = Property.FeelMode.disabled,
defaultValue = "false",
defaultValueType = TemplateProperty.DefaultValueType.Boolean,
group = "query",
type = TemplateProperty.PropertyType.Boolean,
description =
Expand Down