Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inbound): always return health objects with error set #2352

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

chillleader
Copy link
Member

Description

Restores compatibility with web modeler's Problems tab by always returning an error object along with the health response. Additionally, the constructors that allow creating Health objects without an Error were removed.

@chillleader chillleader requested a review from a team as a code owner April 30, 2024 08:51
@chillleader chillleader self-assigned this Apr 30, 2024
Copy link
Contributor

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Ideally, a team member with more experience with the Connectors SDK would also review this 😄

Copy link
Contributor

@johnBgood johnBgood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chillleader chillleader added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit f4ac1e8 Apr 30, 2024
3 checks passed
@chillleader chillleader deleted the return-health-with-error-details branch April 30, 2024 09:24
@chillleader
Copy link
Member Author

/backport

github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Copy link
Contributor

Successfully created backport PR for release/8.6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants