Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saas): apply new operate config #2402

Merged
merged 4 commits into from
May 2, 2024
Merged

Conversation

chillleader
Copy link
Member

Description

Applies the necessary changes to run Connectors in SaaS with the latest Spring Zeebe version.

Related issues

closes https://github.com/camunda/team-connectors/issues/751

@chillleader chillleader requested a review from a team as a code owner May 2, 2024 10:40
@chillleader chillleader self-assigned this May 2, 2024
ev-codes
ev-codes previously approved these changes May 2, 2024
Copy link
Contributor

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chillleader chillleader enabled auto-merge May 2, 2024 10:44
@@ -48,17 +46,4 @@ public void contextLoaded() {
// when the Spring context is initialized (e.g.
// https://github.com/camunda/team-connectors/issues/251)
}

@Test
public void operatePropertiesAreSet() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replace these with a new test?

Perhaps one that checks the JWT credential is configured correctly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@chillleader chillleader requested a review from ev-codes May 2, 2024 10:56
@chillleader chillleader added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 1cab815 May 2, 2024
4 checks passed
@chillleader chillleader deleted the fix-saas-operate-auth branch May 2, 2024 11:38
github-actions bot pushed a commit that referenced this pull request May 2, 2024
* fix(saas): apply new operate config

* lint

* rm old test

* add new test

(cherry picked from commit 1cab815)
Copy link
Contributor

github-actions bot commented May 2, 2024

Successfully created backport PR for release/8.5:

github-actions bot pushed a commit that referenced this pull request May 2, 2024
* fix(saas): apply new operate config

* lint

* rm old test

* add new test

(cherry picked from commit 1cab815)
Copy link
Contributor

github-actions bot commented May 2, 2024

Successfully created backport PR for release/8.6:

chillleader added a commit that referenced this pull request May 2, 2024
* fix(saas): apply new operate config

* lint

* rm old test

* add new test

(cherry picked from commit 1cab815)
chillleader added a commit that referenced this pull request May 2, 2024
* fix(saas): apply new operate config

* lint

* rm old test

* add new test

(cherry picked from commit 1cab815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants