-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inbound): report health UP #2413
Conversation
connectors/aws/aws-sqs/src/test/java/io/camunda/connector/inbound/SqsExecutableTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@chillleader Thanks for this! I suggest we keep this PR open until I confirm with Sara whether QA is required. If QA is required, then I think we should only merge once QA is complete. |
connectors/aws/aws-sns/src/main/java/io/camunda/connector/sns/inbound/SnsWebhookExecutable.java
Show resolved
Hide resolved
@chillleader since this wasn't causing an issue in 8.5, I think we should remove the backport release/8.5 tag. |
@chillleader sorry one more thing - could you please update the description to indicate why this change is needed? (i.e., otherwise health will just be stuck on "unknown") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing everything, approved!
* fix(webhook): report health * fix(kafka): report initial health * fix(sns): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health (cherry picked from commit ac7aba5)
Successfully created backport PR for |
* fix(webhook): report health * fix(kafka): report initial health * fix(sns): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health (cherry picked from commit ac7aba5)
Description
Report Health.UP on startup for Webhook, Kafka, SQS and SNS inbound connectors (otherwise, the health will be stuck on UNKNOWN in the 8.6 release branch)