fix(inbound): report health UP #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
previously approved these changes
May 2, 2024
chillleader
changed the title
johnBgood
reviewed
May 2, 2024
connectors/aws/aws-sqs/src/test/java/io/camunda/connector/inbound/SqsExecutableTest.java
Outdated
Show resolved
Hide resolved
|
@chillleader Thanks for this! I suggest we keep this PR open until I confirm with Sara whether QA is required. If QA is required, then I think we should only merge once QA is complete. |
ev-codes
reviewed
May 2, 2024
connectors/aws/aws-sns/src/main/java/io/camunda/connector/sns/inbound/SnsWebhookExecutable.java
Show resolved
Hide resolved
|
@chillleader since this wasn't causing an issue in 8.5, I think we should remove the backport release/8.5 tag. |
|
@chillleader sorry one more thing - could you please update the description to indicate why this change is needed? (i.e., otherwise health will just be stuck on "unknown") |
ev-codes
approved these changes
May 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 3, 2024
* fix(webhook): report health * fix(kafka): report initial health * fix(sns): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health (cherry picked from commit ac7aba5)
|
Successfully created backport PR for |
chillleader
added a commit
that referenced
this pull request
May 3, 2024
* fix(webhook): report health * fix(kafka): report initial health * fix(sns): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health * fix(sqs): report health (cherry picked from commit ac7aba5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Report Health.UP on startup for Webhook, Kafka, SQS and SNS inbound connectors (otherwise, the health will be stuck on UNKNOWN in the 8.6 release branch)