Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webhook): incorrect type check resulting in missing return data #2442

Merged
merged 4 commits into from
May 3, 2024
Merged

fix(webhook): incorrect type check resulting in missing return data #2442

merged 4 commits into from
May 3, 2024

Conversation

chillleader
Copy link
Member

Description

The type check was invalid and didn't account for subclasses, which lead to missing data.path in the /inbound endpoint response for webhook connectors.

@chillleader chillleader requested a review from a team as a code owner May 3, 2024 10:07
@chillleader chillleader self-assigned this May 3, 2024
ev-codes
ev-codes reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code change itself looks good, just one comment 😄

...ain/java/io/camunda/connector/runtime/inbound/controller/InboundConnectorRestController.java Show resolved Hide resolved
@chillleader chillleader requested a review from ev-codes May 3, 2024 10:35
igpetrov
igpetrov previously approved these changes May 3, 2024
View reviewed changes
ev-codes
ev-codes previously approved these changes May 3, 2024
View reviewed changes
@chillleader chillleader dismissed stale reviews from ev-codes and igpetrov via 9f408f9 May 3, 2024 10:57
@chillleader chillleader requested a review from ev-codes May 3, 2024 10:58
@chillleader chillleader enabled auto-merge May 3, 2024 10:58
@chillleader chillleader added this pull request to the merge queue May 3, 2024
ev-codes
ev-codes approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Merged via the queue into main with commit 3029541 May 3, 2024
7 checks passed
@chillleader chillleader deleted the fix-webhook-type-check branch May 3, 2024 11:29
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@chillleader @github-actions
fix(webhook): incorrect type check resulting in missing return data (#…
bc16042 
…2442)

* fix(webhook): incorrect type check resulting in missing return data

* add test

* add test

* improve test naming

(cherry picked from commit 3029541)
@github-actions github-actions bot mentioned this pull request May 3, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Successfully created backport PR for release/8.6:

chillleader added a commit that referenced this pull request May 3, 2024
@chillleader
fix(webhook): incorrect type check resulting in missing return data (#…
b7d2b2a 
…2442)

* fix(webhook): incorrect type check resulting in missing return data

* add test

* add test

* improve test naming

(cherry picked from commit 3029541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-codes ev-codes ev-codes approved these changes

@igpetrov igpetrov igpetrov left review comments

Assignees

@chillleader chillleader

Labels
backport release/8.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chillleader @ev-codes @igpetrov