Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rest): Bump element template version #2754

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

johnBgood
Copy link
Contributor

@johnBgood johnBgood commented Jun 17, 2024

Description

Bump the REST Connector element template version.
Removes writeTimeoutInSeconds as it's not supported anymore by the connector.

Related issues

#1069

@johnBgood johnBgood self-assigned this Jun 17, 2024
@johnBgood johnBgood requested a review from a team as a code owner June 17, 2024 08:34
Copy link
Contributor

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one note

@@ -108,7 +104,6 @@
"url": "http://localhost:8085/http-endpoint",
"connectionTimeoutInSeconds": 5,
"readTimeoutInSeconds": 67,
"writeTimeoutInSeconds": 34,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you please add an explanation to the PR doc why writeTimeoutInSeconds is removed in all of these templates? Thanks 😄

@johnBgood johnBgood added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit a0facda Jun 17, 2024
3 checks passed
@johnBgood johnBgood deleted the bump-rest-template-version branch June 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants