Compare not existing variables with null #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihme
approved these changes
Aug 25, 2020
| @@ -1150,6 +1153,15 @@ object BuiltinFunctions extends FunctionProvider { | |||
| } | |||
| ) | |||
|
|
|||
| private def isDefinedFunction = | |||
There was a problem hiding this comment.
(Optional) maybe replace it with "is undefined"
There was a problem hiding this comment.
I thought about it. I prefer is defined(x) because it looks more intuitive when inverting it with not(is defined(x)). Instead of having a double negation not(is undefined(x)).
src/test/scala/org/camunda/feel/impl/interpreter/InterpreterExpressionTest.scala
Show resolved
Hide resolved
* a not-existing variable or property can be compared with null * new built-in function `is defined()` that returns true if the given value is present (i.e. is not an error)
saig0
force-pushed
the
150-null-check-for-not-existing
branch
from
79711f5
to
c756a18
Compare
|
@pihme thank you for the fast review 👍 |
saig0
added a commit
that referenced
this pull request
Aug 26, 2020
* a not-existing variable or property can be compared with null * new built-in function `is defined()` that returns true if the given value is present (i.e. is not an error) (cherry picked from commit 21ef10f)
saig0
added a commit
that referenced
this pull request
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nullreturnstruenullreturnstrueif the property isnull, if it doesn't exist, or if its variable isnullor doesn't existis defined()that returnstrueif the given value is present (i.e. is not an error)Related issues
closes #150