Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid creating a reduced pom #451

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jul 4, 2022

Description

  • the reduced pom overrides the original pom when installing the artifacts
  • avoid creating a reduced pom to fix the issue
  • in a previous version of the plugin (3.2.4), no reduced pom was created

Related issues

closes #450

* the reduced pom overrides the original pom when installing the artifacts
* avoid creating a reduced pom to fix the issue
* in a previous version of the plugin (3.2.4), no reduced pom was created
@saig0 saig0 marked this pull request as ready for review July 4, 2022 08:23
@saig0 saig0 requested review from tasso94 and korthout July 4, 2022 08:23
@saig0
Copy link
Member Author

saig0 commented Jul 4, 2022

@tasso94 please have a look if this is okay for Camunda Platform 7. I assume so because the reduced pom was not generated before, even if it was configured to do so 😅

@saig0
Copy link
Member Author

saig0 commented Jul 4, 2022

cc: @korthout to let you know about it

Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@saig0 saig0 merged commit cc17efe into master Jul 6, 2022
@saig0 saig0 deleted the 450-maven-shade-plugin branch July 6, 2022 03:31
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Successfully created backport PR #459 for 1.14.

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Successfully created backport PR #460 for 1.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.15.0 doesn't have a compile dependency to fastparse
2 participants