build: Fix licence check #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the configuration of the license plugin into the plugin management section to override the parent POM. Create two profiles: one profile for adding license headers and apply formatting, and another profile for only checking if license headers are present. The second profile is used in the CI. The first profile is used by default for local development.
The missing license headers were generate using the licence Maven plugin.
|
@korthout just a small fix in the build to enable the license plugin again. Please have a look when you have time. 🍪 |
korthout
approved these changes
Jul 25, 2023
Comment on lines
+416
to
+418
| <activation> | ||
| <activeByDefault>true</activeByDefault> | ||
| </activation> |
There was a problem hiding this comment.
💭 One thing to remember with activeByDefault is that it will be deactivated automatically when any other profile is activated. I always thought this was unexpected. There exist some solutions to deal with this (I personally like activeProfile best), if you wish to take that route.
There was a problem hiding this comment.
Good to know. Thank you for the hint. 👍
.github/workflows/build-maven.yml
Outdated
| run: mvn -B clean verify com.mycila:license-maven-plugin:check | ||
| run: mvn -B clean -P !autoFormat,checkFormat verify |
There was a problem hiding this comment.
🔧 With activeByDefault you don't need to disable the autoFormat profile. Simply by activating the checkFormat profile, the autoFormat profile will already be disabled.
The autoFormat profile is activated by default. If the checkFormat profile is enabled, the default profile is disable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues