Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.16] fix: Invoke context() function with a list containing a custom context #861

Merged
merged 4 commits into from
May 31, 2024

Conversation

saig0
Copy link
Member

@saig0 saig0 commented May 30, 2024

Description

Backport of #858 to 1.16.

Related issues

relates to #856

saig0 added 4 commits May 30, 2024 14:43
Merge test class with the new style from version 1.17.
(cherry picked from commit f3e7370)
The context function expects a list argument with context entries that contain a key and a value. The function checks that the key value is a string. To support a custom context value, the value must be resolved via value-mapper first before checking the type. Otherwise, the value may be not a FEEL Val type but something else.

(cherry picked from commit 2416531)
@saig0 saig0 requested a review from berkaycanbc May 30, 2024 12:51
Copy link
Contributor

@berkaycanbc berkaycanbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we also used the new expression evaluation function in the existing tests. 🚀

@saig0 saig0 merged commit d9c9730 into 1.16 May 31, 2024
3 checks passed
@saig0 saig0 deleted the backport-856-for-1.16 branch May 31, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants