Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs to transfer the variables when failing a job has variables #10700

Closed
skayliu opened this issue Oct 13, 2022 · 0 comments · Fixed by #10702
Closed

Needs to transfer the variables when failing a job has variables #10700

skayliu opened this issue Oct 13, 2022 · 0 comments · Fixed by #10702
Assignees
@korthout @skayliu
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha1 Marks an issue as being completely or in parts released in 8.2.0-alpha1 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@skayliu
Copy link
Contributor

skayliu commented Oct 13, 2022 •
edited

Is your feature request related to a problem? Please describe.

If a failling job has variables:

  • the FailJob gRPC api needs to set a param varialbes.
  • the variables needs to be transfered from gateway to broker.

client.newFailCommand(...).variables(...)

Describe the solution you'd like

  • Add a param variables for the FailJob gRPC api.
  • Transfer the variables when failing a job has variables.

Describe alternatives you've considered

No.

Additional context

Related #9404
@skayliu skayliu added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Oct 13, 2022
@skayliu skayliu changed the title Needs to set a param variables for the FailJob gRPC api Needs to transfer the variables when failling a job has variables Oct 13, 2022
@skayliu skayliu changed the title Needs to transfer the variables when failling a job has variables Needs to transfer the variables when failing a job has variables Oct 13, 2022
@skayliu skayliu mentioned this issue Oct 13, 2022
Merged
10 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Oct 17, 2022
@zeebe-bors-camunda @skayliu
merge: #10702
1f3bb75 
10702: feat(gateway): add fail job variables support r=korthout a=skayliu

## Description

Add variables param for FailJob api and transfer variables from gateway to broker.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #10700 



Co-authored-by: skayliu <skay463@163.com>
@korthout korthout added the version:8.2.0-alpha1 Marks an issue as being completely or in parts released in 8.2.0-alpha1 label Nov 1, 2022
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korthout korthout

@skayliu skayliu

Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha1 Marks an issue as being completely or in parts released in 8.2.0-alpha1 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gateway): add fail job variables support skayliu/zeebe
3 participants
@npepinpe @korthout @skayliu