Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose standalone Decision evaluation in the Gateway #11047

Closed
3 tasks done
Tracked by #11037
koevskinikola opened this issue Nov 18, 2022 · 1 comment · Fixed by #11281
Closed
3 tasks done
Tracked by #11037

Expose standalone Decision evaluation in the Gateway #11047

koevskinikola opened this issue Nov 18, 2022 · 1 comment · Fixed by #11281
Assignees
@koevskinikola
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha4 Marks an issue as being completely or in parts released in 8.2.0-alpha4 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@koevskinikola
Copy link
Member

koevskinikola commented Nov 18, 2022 •
edited

Is your feature request related to a problem? Please describe.
Provide an API to trigger standalone Decision evaluation in the workflow engine.

Describe the solution you'd like

  • Define EvaluateDecisionRequest and EvaluateDecisionResponse messages and their properties in the gRPC protocol (gateway-protocol module).
  • Define a Broker*Request, and map the new gRPC messages in the gateway module.
  • Use the DecisionEvaluationRecord expanded by Enable standalone Decision execution in the engine #11039

Describe alternatives you've considered
/

Additional context
/

Blocked by
@koevskinikola koevskinikola added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Nov 18, 2022
@koevskinikola koevskinikola self-assigned this Nov 18, 2022
This was referenced Nov 18, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@koevskinikola koevskinikola mentioned this issue Dec 15, 2022
Merged
14 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Dec 22, 2022
@zeebe-bors-camunda @koevskinikola
merge: #11281
c0a3bc3 
11281: feat(gateway): add gateway api for standalone decision evaluation r=koevskinikola a=koevskinikola

## Description

Expose the new `EvaluateDecisionProcessor` in the engine through the Gateway API.

## Related issues

closes #11047, closes #11050



Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 22, 2022
@zeebe-bors-camunda @koevskinikola @skayliu
merge: #11281 #11296
e8e216e 
11281: feat(gateway): add gateway api for standalone decision evaluation r=koevskinikola a=koevskinikola

## Description

Expose the new `EvaluateDecisionProcessor` in the engine through the Gateway API.

## Related issues

closes #11047, closes #11050



11296: Add record, intent, stream and export to elasticsearch for signal r=korthout a=skayliu

## Description

Add record, intent, stream and export to elasticsearch for signal.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #11295 



Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
Co-authored-by: skayliu <skay463@163.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 23, 2022
@zeebe-bors-camunda @koevskinikola
merge: #11281
3008c29 
11281: feat(gateway): add gateway api for standalone decision evaluation r=koevskinikola a=koevskinikola

## Description

Expose the new `EvaluateDecisionProcessor` in the engine through the Gateway API.

## Related issues

closes #11047, closes #11050



Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 23, 2022
@zeebe-bors-camunda @koevskinikola
merge: #11281
acecbc9 
11281: feat(gateway): add gateway api for standalone decision evaluation r=koevskinikola a=koevskinikola

## Description

Expose the new `EvaluateDecisionProcessor` in the engine through the Gateway API.

## Related issues

closes #11047, closes #11050



Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 23, 2022
@zeebe-bors-camunda @koevskinikola
merge: #11281
623c7e4 
11281: feat(gateway): add gateway api for standalone decision evaluation r=Zelldon a=koevskinikola

## Description

Expose the new `EvaluateDecisionProcessor` in the engine through the Gateway API.

## Related issues

closes #11047, closes #11050



Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Dec 23, 2022
@zeebe-bors-camunda @koevskinikola
merge: #11281
0a0d681 
11281: feat(gateway): add gateway api for standalone decision evaluation r=Zelldon a=koevskinikola

## Description

Expose the new `EvaluateDecisionProcessor` in the engine through the Gateway API.

## Related issues

closes #11047, closes #11050



Co-authored-by: Nikola Koevski <nikola.koevski@camunda.com>
@koevskinikola koevskinikola mentioned this issue Dec 23, 2022
Closed
@koevskinikola
Copy link
Member Author

koevskinikola commented Dec 23, 2022 •
edited

This issue was implemented together with #11050 in PR #11281.

The reason was that a decision evaluation may fail due to another decision that it depends on. In this case, a failure message, and an ID of the failed decision are provided.

Providing the standalone decision evaluation feature without failure information would be incomplete. And providing failure information without the intermediate evaluations would make the failure information incomplete as well.

As a result, both issues were implemented at once.

@jwulf jwulf mentioned this issue Jan 30, 2023
Closed
@koevskinikola koevskinikola added the version:8.2.0-alpha4 Marks an issue as being completely or in parts released in 8.2.0-alpha4 label Feb 8, 2023
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koevskinikola koevskinikola

Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.2.0-alpha4 Marks an issue as being completely or in parts released in 8.2.0-alpha4 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gateway): add gateway api for standalone decision evaluation camunda/zeebe
2 participants
@npepinpe @koevskinikola