Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After unrecoverable errors, ZeebePartition accesses closed raft context #11070

Closed
oleschoenburg opened this issue Nov 22, 2022 · 1 comment · Fixed by #11445
Closed

After unrecoverable errors, ZeebePartition accesses closed raft context #11070

oleschoenburg opened this issue Nov 22, 2022 · 1 comment · Fixed by #11445
Assignees
Labels
component/partition-transitions kind/bug Categorizes an issue or PR as a bug version:8.1.7 Marks an issue as being completely or in parts released in 8.1.7 version:8.2.0-alpha4 Marks an issue as being completely or in parts released in 8.2.0-alpha4 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@oleschoenburg
Copy link
Member

Describe the bug

When handling unrecoverable errors, ZeebePartition shuts down the raft context:

which triggers an async transition to inactive:

Because this transition is async, the ZeebePartition continues to run on a closed raft context which can cause various issues, for example attempts to access a closed journal. This can then cause further issues, for example failed transitions.

Expected behavior

When the ZeebePartition decides to close the raft context, it should first remove itself as a role change listener, trigger the transition to INACTIVE itself and only close the raft context on completion of the transition.

related to #10776

@oleschoenburg oleschoenburg added the kind/bug Categorizes an issue or PR as a bug label Nov 22, 2022
@oleschoenburg oleschoenburg self-assigned this Nov 24, 2022
@megglos
Copy link
Contributor

megglos commented Nov 25, 2022

Impact: as of now Log noise if a partition is dead, potential for critical bugs
Will put into ready to get it solved before it becomes an issue.

zeebe-bors-camunda bot added a commit that referenced this issue Jan 19, 2023
11447: [Backport stable/8.0] fix(broker): transition to inactive before stopping raft partition r=deepthidevaki a=backport-action

# Description
Backport of #11445 to `stable/8.0`.

relates to #11070

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jan 19, 2023
11448: [Backport stable/8.1] fix(broker): transition to inactive before stopping raft partition r=deepthidevaki a=backport-action

# Description
Backport of #11445 to `stable/8.1`.

relates to #11070

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@koevskinikola koevskinikola added the version:8.2.0-alpha4 Marks an issue as being completely or in parts released in 8.2.0-alpha4 label Feb 8, 2023
@koevskinikola koevskinikola added the version:8.1.7 Marks an issue as being completely or in parts released in 8.1.7 label Feb 10, 2023
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/partition-transitions kind/bug Categorizes an issue or PR as a bug version:8.1.7 Marks an issue as being completely or in parts released in 8.1.7 version:8.2.0-alpha4 Marks an issue as being completely or in parts released in 8.2.0-alpha4 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants