Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null pointer exception if update last position in exporter close call #1334

Closed
menski opened this issue Sep 13, 2018 · 0 comments · Fixed by #1750
Closed

Null pointer exception if update last position in exporter close call #1334

menski opened this issue Sep 13, 2018 · 0 comments · Fixed by #1750
Assignees
@MiguelPires
Labels
kind/bug Categorizes an issue or PR as a bug
Milestone
Exporter

Comments

@menski
Copy link
Contributor

menski commented Sep 13, 2018 •
edited

If an exporter flushes in the close method and updates the last position an new actor task is scheduled in the ExpoterStreamProcessor.

https://github.com/zeebe-io/zeebe/blob/63a17b4d012638eecdad14a7ade1d9fa98c760f0/broker-core/src/main/java/io/zeebe/broker/exporter/stream/ExporterStreamProcessor.java#L172-L178

But before this can be executed the state database is already closed, so a NPE is thrown.

https://github.com/zeebe-io/zeebe/blob/63a17b4d012638eecdad14a7ade1d9fa98c760f0/broker-core/src/main/java/io/zeebe/broker/exporter/stream/ExporterStreamProcessor.java#L140-L150
@menski menski added the bug label Sep 13, 2018
@menski menski added this to the Exporter milestone Sep 13, 2018
@menski menski mentioned this issue Sep 17, 2018
Merged
@ghost ghost assigned menski Sep 17, 2018
@ghost ghost added the needs review label Sep 17, 2018
@menski menski added ready and removed needs review labels Sep 18, 2018
@menski menski removed their assignment Sep 18, 2018
bors bot added a commit that referenced this issue Sep 19, 2018
@bors @menski
Merge #1344
4f732bf 
1344: Add elasticsearch exporter r=menski a=menski

- basic implementation for a generic elasticsearch exporter
- the exporter is currently added to the distribution to ease the getting started experience, this should be challenged in the near future
- the exporter might break the broker in case of an exception, we need to discuss the exception/error concept of exporters
- set deadline of job records to null if deadline is not set

closes #1326
workaround for #1334 

follow up issues #1341, #1342 and #1343


Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Co-authored-by: Sebastian Menski <sebastian@menski.org>
bors bot added a commit that referenced this issue Sep 19, 2018
@bors @menski
Merge #1344
286167e 
1344: Add elasticsearch exporter r=menski a=menski

- basic implementation for a generic elasticsearch exporter
- the exporter is currently added to the distribution to ease the getting started experience, this should be challenged in the near future
- the exporter might break the broker in case of an exception, we need to discuss the exception/error concept of exporters
- set deadline of job records to null if deadline is not set

closes #1326
workaround for #1334 

follow up issues #1341, #1342 and #1343


Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Co-authored-by: Sebastian Menski <sebastian@menski.org>
@menski menski removed the ready label Oct 17, 2018
@menski menski added the planned label Oct 26, 2018
@MiguelPires MiguelPires mentioned this issue Dec 5, 2018
Merged
@ghost ghost added needs review and removed in progress labels Dec 5, 2018
@menski menski added Status: Needs Review kind/bug Categorizes an issue or PR as a bug and removed needs review labels Dec 11, 2018
zeebe-bors-heroku bot pushed a commit that referenced this issue Dec 12, 2018
@zeebe-bors
Merge #1750
e6ee8ea 
1750: fix(broker-core): don't schedule task for update position if in actor r=MiguelPires a=MiguelPires

Avoid scheduling the update of the last record position when the call is made in the actor.
Also deletes the RocksDB folder (which wasn't happening on Windows)


closes #1334 


Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
@ghost ghost removed the Status: Needs Review label Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiguelPires MiguelPires

Labels
kind/bug Categorizes an issue or PR as a bug
Projects
None yet
Milestone
Exporter
Development

Successfully merging a pull request may close this issue.

fix(broker-core): don't schedule task for update position if in actor camunda/zeebe
2 participants
@menski @MiguelPires