Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race condition on Job activation between Gateway and Broker #4239

Closed
Zelldon opened this issue Apr 6, 2020 · 2 comments
Closed
Labels
kind/bug Categorizes an issue or PR as a bug kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Milestone

Comments

@Zelldon
Copy link
Member

Zelldon commented Apr 6, 2020

Description

During our engine latency investigation we observed sometimes a high latency of the job activation. We found out that this high latency stand in relation to the LongPollingTimeout. Further think about this, bring us to the point that it might be a race condition between gateway and broker.

If the Gateway requested jobs multiple times after a certain amount (i think after three retries) it will switch to long polling. It might happen that between switching to long polling and establishing the job subscription a new job is created on the broker side and the notification which is send might get lost. After the long poll timesout the client will retry and the job will be activated successfully.

This can also be avoid with using more then one worker.

@Zelldon Zelldon added kind/bug Categorizes an issue or PR as a bug kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog labels Apr 6, 2020
@Zelldon
Copy link
Member Author

Zelldon commented Apr 6, 2020

@falko feel free to add your two cents

@Zelldon Zelldon added this to the Maintenance milestone Apr 7, 2020
@menski
Copy link
Contributor

menski commented Apr 28, 2020

replaced by #4396

@menski menski closed this as completed Apr 28, 2020
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
…o v2.12.0 (master) (#4239)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes an issue or PR as a bug kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Development

No branches or pull requests

2 participants