Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io.atomix.cluster.messaging.impl.DefaultClusterEventServiceTest.testClusterEventService is flaky #4307

Closed
npepinpe opened this issue Apr 14, 2020 · 2 comments · Fixed by #4387
Closed

io.atomix.cluster.messaging.impl.DefaultClusterEventServiceTest.testClusterEventService is flaky #4307

npepinpe opened this issue Apr 14, 2020 · 2 comments · Fixed by #4387
Assignees
@deepthidevaki
Labels
kind/flake Categorizes issue or PR as related to a flaky test scope/broker Marks an issue or PR to appear in the broker section of the changelog
Milestone
CI Builds should ...

Comments

@npepinpe
Copy link
Member

Summary

Try to answer the following as best as possible

  • How often does the test fail?
    Seen it a few times, but not necessarily more than other flaky tests

  • Does it block your work?
    To some extent, blocks merging PRs.

  • Do we suspect that it is a real failure?
    Could be; the DefaultClusterEventService is known to be quite buggy, so I wouldn't be surprised.

Failures

Example assertion failure 
Error
expected:<3> but was:<0>
Stacktrace
java.lang.AssertionError: expected:<3> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at io.atomix.cluster.messaging.impl.DefaultClusterEventServiceTest.testClusterEventService(DefaultClusterEventServiceTest.java:193)
...

Hypotheses

Nothing in particular, but this service is known to be buggy in general, see #4154

Logs

Logs 
14:55:06.742 [] INFO  io.zeebe.test - Test started: testClusterEventService(io.atomix.cluster.messaging.impl.DefaultClusterEventServiceTest)
14:55:07.262 [] INFO  io.atomix.cluster.discovery.BootstrapDiscoveryProvider - Joined
14:55:07.266 [] INFO  io.atomix.cluster.protocol.HeartbeatMembershipProtocol - 1 - Member activated: Member{id=1, address=localhost:1, host=localhost, properties={}}
14:55:07.342 [] INFO  io.atomix.cluster.protocol.HeartbeatMembershipProtocol - Started
14:55:07.347 [] INFO  io.atomix.cluster.impl.DefaultClusterMembershipService - Started
14:55:07.444 [] INFO  io.atomix.cluster.messaging.impl.DefaultClusterEventService - Started
14:55:07.447 [] INFO  io.atomix.cluster.discovery.BootstrapDiscoveryProvider - Joined
14:55:07.447 [] INFO  io.atomix.cluster.protocol.HeartbeatMembershipProtocol - 2 - Member activated: Member{id=2, address=localhost:2, host=localhost, properties={}}
14:55:07.453 [] INFO  io.atomix.cluster.protocol.HeartbeatMembershipProtocol - Started
14:55:07.454 [] INFO  io.atomix.cluster.impl.DefaultClusterMembershipService - Started
14:55:07.456 [] INFO  io.atomix.cluster.messaging.impl.DefaultClusterEventService - Started
14:55:07.459 [] INFO  io.atomix.cluster.discovery.BootstrapDiscoveryProvider - Joined
14:55:07.460 [] INFO  io.atomix.cluster.protocol.HeartbeatMembershipProtocol - 3 - Member activated: Member{id=3, address=localhost:3, host=localhost, properties={}}
14:55:07.464 [] INFO  io.atomix.cluster.protocol.HeartbeatMembershipProtocol - Started
14:55:07.466 [] INFO  io.atomix.cluster.impl.DefaultClusterMembershipService - Started
14:55:07.469 [] INFO  io.atomix.cluster.messaging.impl.DefaultClusterEventService - Started
@npepinpe npepinpe added scope/broker Marks an issue or PR to appear in the broker section of the changelog kind/flake Categorizes issue or PR as related to a flaky test labels Apr 14, 2020
@pihme pihme added this to the CI Builds should reflect state milestone Apr 16, 2020
@deepthidevaki deepthidevaki self-assigned this Apr 17, 2020
@deepthidevaki deepthidevaki mentioned this issue Apr 17, 2020
Closed
3 tasks
@deepthidevaki deepthidevaki mentioned this issue Apr 27, 2020
Merged
3 tasks
zeebe-bors bot added a commit that referenced this issue Apr 29, 2020
@zeebe-bors @deepthidevaki
Merge #4387
56f5613 
4387: Refactor cluster event service r=deepthidevaki a=deepthidevaki

## Description

* Use member properties to propagate subscription info instead of custom gossip
* EventService can now only  `broadcast`. Methods for unicast and send are removed from the interface. 

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #4154 
closes #4307 

#

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@zeebe-bors zeebe-bors bot closed this as completed in 86d86d1 Apr 29, 2020
@korthout
Copy link
Member

Seen again in https://ci.zeebe.camunda.cloud/blue/organizations/jenkins/zeebe-io%2Fzeebe/detail/staging/1671/pipeline/82

@korthout korthout reopened this Jun 24, 2020
@korthout korthout mentioned this issue Jun 24, 2020
Merged
@korthout
Copy link
Member

I'm mistaken, the merged PR above is just not part of the backport yet. I guess that's fine.

github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
@renovate @vsgoulart
chore(deps): update all non-major dependencies (master) (#4307)
a4e38bc 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vinicius Goulart <vinicius.goulart@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
kind/flake Categorizes issue or PR as related to a flaky test scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Milestone
CI Builds should reflect state
5 participants
@npepinpe @deepthidevaki @korthout @pihme @KerstinHebel