Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly handle duplicated task headers #9416

Closed
lenaschoenburg opened this issue May 19, 2022 · 3 comments · Fixed by #9623
Closed

Explicitly handle duplicated task headers #9416

lenaschoenburg opened this issue May 19, 2022 · 3 comments · Fixed by #9623
Assignees
@pihme
Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@lenaschoenburg
Copy link
Member

Description

When deploying a model where a service task has more than one custom header with the same key, an error is raised and the deploy fails.

The error message returned on deploy is pretty clear:
image

But the error is not handled explicitly:
https://github.com/camunda/zeebe/blob/2c793910c4ed5a996c40f0b1b52b346880edb551/engine/src/main/java/io/camunda/zeebe/engine/processing/deployment/model/transformer/zeebe/TaskHeadersTransformer.java#L38-L41

We should handle this a bit more gracefully so that the error does not show up in our error reporting tool: https://console.cloud.google.com/errors/detail/CPr11a6I_KbY6gE;service=zeebe;time=P7D?project=camunda-cloud-240911

Related discussion on Slack: https://camunda.slack.com/archives/CSQ2E3BT4/p1652943416460409

BPMN file to reproduce: duplicatetaskheaders.zip
@lenaschoenburg lenaschoenburg added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) team/process-automation labels May 19, 2022
@saig0
Copy link
Member

saig0 commented Jun 10, 2022 •
edited
Loading

This is a good case for linting. Let's create an issue when we work on it.

@pihme pihme self-assigned this Jun 23, 2022
@pihme
Copy link
Contributor

pihme commented Jun 23, 2022 •
edited
Loading

@saig0 In which repo should I create the linting issue?

@saig0
Copy link
Member

saig0 commented Jun 27, 2022

@pihme I think we should create the issue here: https://github.com/camunda/linting

This was referenced Jun 27, 2022
Closed
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Jun 29, 2022
@zeebe-bors-camunda @pihme
merge: #9623
376d57e 
9623: 9416 duplicate task headers r=pihme a=pihme

## Description
Adds a validation that adds an error when headers have duplicate keys.

## Related issues

closes #9416



Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 29, 2022
@zeebe-bors-camunda @pihme
merge: #9623
f54b8e6 
9623: 9416 duplicate task headers r=pihme a=pihme

## Description
Adds a validation that adds an error when headers have duplicate keys.

## Related issues

closes #9416



Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 29, 2022
@zeebe-bors-camunda @pihme
merge: #9623
155285f 
9623: 9416 duplicate task headers r=pihme a=pihme

## Description
Adds a validation that adds an error when headers have duplicate keys.

## Related issues

closes #9416



Co-authored-by: pihme <pihme@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this issue Jun 29, 2022
@zeebe-bors-camunda @pihme
merge: #9623
c1da0b2 
9623: 9416 duplicate task headers r=pihme a=pihme

## Description
Adds a validation that adds an error when headers have duplicate keys.

## Related issues

closes #9416



Co-authored-by: pihme <pihme@users.noreply.github.com>
@lenaschoenburg lenaschoenburg added the version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 label Jul 5, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pihme pihme

Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha3 Marks an issue as being completely or in parts released in 8.1.0-alpha3 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

9416 duplicate task headers camunda/camunda
4 participants
@lenaschoenburg @Zelldon @saig0 @pihme