Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the backport action from looping endlessly #9490

Closed
lenaschoenburg opened this issue Jun 2, 2022 · 0 comments · Fixed by #9492
Closed

Prevent the backport action from looping endlessly #9490

lenaschoenburg opened this issue Jun 2, 2022 · 0 comments · Fixed by #9492
Assignees
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@lenaschoenburg
Copy link
Member

Description

In a recent PR, the backport action triggered itself, causing an endless loop.

This happened because the backport action is triggered on issue comments that contain the string /backport:
https://github.com/camunda/zeebe/blob/3ff54bfbeba499ad8c317465e043857f1c4872dd/.github/workflows/backport.yml#L1-L21

and on backport failure, it adds a comment that contains that string: #9411 (comment)

Previously, this wasn't an issue. Presumably, this is because we recently switched to using a PAT instead of the generic github-actions bot account: #9426

We should adjust the condition that triggers the backport action to either skip comments that are created by the @backport-action user or by restricting the condition so that the /backport must appear at the end of the comment.

We should also add some warnings upstream so that other users don't run into the same issue: https://github.com/zeebe-io/backport-action.

Once we have fixed this behavior, we should also re-enable the backport workflow: https://github.com/camunda/zeebe/actions/workflows/backport.yml

@lenaschoenburg lenaschoenburg added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) labels Jun 2, 2022
@remcowesterhoud remcowesterhoud self-assigned this Jun 2, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha2 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants