Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(backup-stores/s3): increase timeout #10504

Merged
merged 1 commit into from
Sep 27, 2022
Merged

test(backup-stores/s3): increase timeout #10504

merged 1 commit into from
Sep 27, 2022

Conversation

deepthidevaki
Copy link
Contributor

Description

The timeout was too low, resulting in flaky tests. Set it to 1 minute. This might be too much for this test, but it is better than encountering flakiness again.

Related issues

closes #10500

lenaschoenburg
lenaschoenburg approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was a fast one 🚀

bors r+

@github-actions
Copy link
Contributor

Test Results

   932 files  ±  0     932 suites  ±0   1h 59m 53s ⏱️ - 1m 36s
7 363 tests +84  7 353 ✔️ +84  10 💤 ±0  0 ❌ ±0 
7 551 runs  +84  7 541 ✔️ +84  10 💤 ±0  0 ❌ ±0 

Results for commit 3756350. ± Comparison against base commit 6c9f7e4.

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit f915b56 into main Sep 27, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the dd-10500-flaky-backup branch September 27, 2022 06:53
@backport-action backport-action mentioned this pull request Sep 27, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10507 for release-8.1.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 27, 2022
@zeebe-bors-camunda @deepthidevaki
merge: #10507
3020dff 
10507: [Backport release-8.1.0] test(backup-stores/s3): increase timeout r=oleschoenburg a=backport-action

# Description
Backport of #10504 to `release-8.1.0`.

relates to #10500

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaschoenburg lenaschoenburg lenaschoenburg approved these changes

Assignees
No one assigned
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalstackBackupStoreIT#shouldNotOverwriteCompletedBackup(Backup)[1]
4 participants
@deepthidevaki @backport-action @lenaschoenburg @Zelldon