Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backup manager metrics should be prefixed with 'backup' #10513

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix: backup manager metrics should be prefixed with 'backup' #10513

merged 1 commit into from
Sep 27, 2022

Conversation

lenaschoenburg
Copy link
Member

@lenaschoenburg lenaschoenburg commented Sep 27, 2022 •
edited
Loading

I didn't use the 'backup' in the name of metrics introduced for #10386, this PR fixes it.

deepthidevaki
deepthidevaki approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

bors r+

@github-actions
Copy link
Contributor

Test Results

   932 files  ±  0     932 suites  ±0   2h 5m 21s ⏱️ - 8m 26s
7 215 tests  - 91  7 205 ✔️  - 91  10 💤 ±0  0 ❌ ±0 
7 403 runs   - 91  7 393 ✔️  - 91  10 💤 ±0  0 ❌ ±0 

Results for commit 179985c. ± Comparison against base commit 01f5df2.

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 686875c into main Sep 27, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the os-fix-backup-metrics-name branch September 27, 2022 09:54
@backport-action backport-action mentioned this pull request Sep 27, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10514 for release-8.1.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 27, 2022
@zeebe-bors-camunda @lenaschoenburg
merge: #10514
d5d1f32 
10514: [Backport release-8.1.0] fix: backup manager metrics should be prefixed with 'backup' r=oleschoenburg a=backport-action

# Description
Backport of #10513 to `release-8.1.0`.

relates to 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees
No one assigned
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lenaschoenburg @backport-action @deepthidevaki @Zelldon