test: don't fail test if scheduled task runs more often than expected

[oleschoenburg]

If the test thread was blocked for a while, for example due to garbage collection, verifying that the task ran exactly 5 times within 2 seconds would fail because it ran more often than that.

With this change we just verify that the task ran at least 5 times within 2 seconds.

closes #10745

[github-actions]

Test Results

   939 files  ±  0     939 suites  ±0   1h 46m 23s ⏱️ +34s
7 620 tests +78  7 613 ✔️ +79  7 💤 ±0  0 ❌  - 1 
7 810 runs  +78  7 801 ✔️ +79  9 💤 ±0  0 ❌  - 1 

Results for commit f4273e2. ± Comparison against base commit 0d9dba6.

[deepthidevaki]

It doesn't look like this test is testing really what it wants. To make it deterministic, one way would be to use ControlledActorScheduler. Then we can write:

    scheduleService.runAtFixedRate(Duration.ofSeconds(10), mockedTask);
    actorScheduler.runUntilDone();

    // verify it ran at the first interval
    clock.addTime(Duration.ofSeconds(10));
    actorScheduler.runUntilDone();
    verify(mockedTask, times(1)).execute(any());
 
   // verify it was rescheduled for the next interval
    clock.addTime(Duration.ofSeconds(10));
    actorScheduler.runUntilDone();
    verify(mockedTask, times(2)).execute(any());

What do you think?

[oleschoenburg]

I interpreted the test more as a "see if runAtFixedRate works at all" test and not so much as a test that verifies specific timings.

I think it makes sense to test that runAtFixedRate runs jobs at a rate that is close to the requested rate but that'd be a separate test IMO.

[deepthidevaki]

Ok. Then this test is enough. I don't think another test is required. I assume time based scheduling is already tested for actor scheduler.

[deepthidevaki]

Thanks 🎉

[oleschoenburg]

bors merge

[zeebe-bors-camunda]

Build succeeded:

• Test summary

[backport-action]

Successfully created backport PR #10750 for stable/8.1.