Reset active sequence flows upon terminate end event activation #10789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 948 files ± 0 948 suites ±0 1h 42m 6s ⏱️ - 2m 41s For more details on these failures, see this check. Results for commit 13d00b2. ± Comparison against base commit c5f0f0a. ♻️ This comment has been updated with latest results. |
saig0
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
@remcowesterhoud looks good. 👍
I have one optional suggestion. Please have a look.
...ain/java/io/camunda/zeebe/engine/state/appliers/ProcessInstanceElementActivatingApplier.java
Outdated
Show resolved
Hide resolved
… completed After a terminate end event has been completed the flow scope should be completed as well. When there are active sequence flows this doesn't happen as we have checks preventing a flow scope from completing when there is any active element instance or active sequence flow. By resetting this when the terminate end event is completed we can pass this check.
remcowesterhoud
force-pushed
the
10590_parallel_gateway_terminate_end_event
branch
from
64f5a93
to
13d00b2
Compare
|
bors merge |
|
Build succeeded: |
zeebe-bors-camunda
bot
deleted the
10590_parallel_gateway_terminate_end_event
branch
|
Successfully created backport PR #10821 for |
korthout
added
the
version:8.1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a terminate end event has been completed the flow scope should be completed as well. When there are active sequence flows this doesn't happen as we have checks preventing a flow scope from completing when there is any active element instance or active sequence flow. By resetting this on activation of the terminate end event we can pass this check.
Related issues
closes #10590
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.