New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ClusteringRule for SecureClusteredMessagingIT #10823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran it several times (> 20), and it's generally green. There's another 10 runs coming just to verify, but I think it can be reviewed already. |
deepthidevaki
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀 Hope this fixes the flaky test 🤞
qa/integration-tests/src/test/java/io/camunda/zeebe/it/network/SecureClusteredMessagingIT.java
Outdated
Show resolved
Hide resolved
npepinpe
force-pushed
the
10655-ditch-docker
branch
from
October 27, 2022 08:01
bd6ee74
to
05488ec
Compare
bors merge |
Build succeeded: |
Successfully created backport PR #10829 for |
korthout
added
the
version:8.1.3
Marks an issue as being completely or in parts released in 8.1.3
label
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rewrites the existing
SecureClusteredMessagingIT
to use theClusteringRule
instead of containers. This is in attempt to fix the the flakiness where, every once in a while, the gateway's messaging service is not accessible from the outside (and only in CI).The assumption is that, since we've verified the nodes are still talking to each other fine, this is not a production issue but an environmental one, so rewriting the test to modify the environment is a valid solution (if incomplete, as root causing the problem would have been preferable of course). As we've already spent too much time on this, however, root causing was shelved in favor of this approach.
Related issues
closes #10655
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.