Increase timeout and add logging #10868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the timeout we wait for the topology to be complete from 15 seconds to 30 seconds. The idea is that 15 may be right on the cusp of the minimum limit we've observed, due to possibly requiring up to 5 seconds for a node to be elected, and hypothetical long GC pauses. This doesn't not unflake the test, but hopefully the next time it fails we have a better idea of what is happening. At the same time, the test is updated to junit 5, and the gateway (from which we get the topology) is also configured for faster gossip, like the broker.
|
bors merge |
|
Build succeeded: |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-10868-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-10868-to-stable/8.0
git checkout -b backport-10868-to-stable/8.0
ancref=$(git merge-base b8e2293ee4a7f0901aacb2bb19f32c3a00ff10ab 9d30d71bcee847176265c91124166385fc5e4143)
git cherry-pick -x $ancref..9d30d71bcee847176265c91124166385fc5e4143 |
|
Successfully created backport PR #10870 for |
korthout
added
the
version:8.1.3
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 2, 2022
10871: [Backport stable/8.0] Increase timeout and add logging r=oleschoenburg a=npepinpe # Description Backport of #10868 to `stable/8.1`. relates to #10234 # Conflicts There was a minor conflict in `ClusteringRule` around the logging added, mostly due to the changes we did when we moved the construction of `AtomixCluster` into the dist module. Nothing major, just add to move a line. The PR also backports the `ClusteringRuleExtension`, as it will be useful in the future for more backports, I think. Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases the timeout of the assertion from 15 to 30 seconds, and adds more diagnostic logging for easier debugging next time this occurs (if it does 🤞).
See the last comment for more, specifically the last paragraph.
Related issues
related to #10234
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.